Actions: Fix FP in envvar injection - #22235
Open
JarLob wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves environment variable injection precision by correlating untrusted sources with privileged trigger events and excluding newline-safe PR head labels.
Changes:
- Correlates critical findings with their originating event.
- Excludes pull request head labels as injection sources.
- Adds regression fixtures and updates expected results.
Show a summary per file
| File | Description |
|---|---|
EnvVarInjectionMedium.expected |
Updates generated medium-query expectations. |
EnvVarInjectionCritical.expected |
Updates generated critical-query expectations. |
.github/workflows/test4.yml |
Adds PR head-label regression coverage. |
.github/workflows/test18.yml |
Adds event-correlation regression coverage. |
EnvVarInjectionCritical.ql |
Requires matching source and privilege events. |
2026-07-18-envvar-injection-precision.md |
Documents the precision improvements. |
EnvVarInjectionQuery.qll |
Excludes label sources from taint tracking. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
Author
|
@redsun82 Could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.